This repository was archived by the owner on Jun 21, 2018. It is now read-only.
Merged
Conversation
Member
|
What's blocking the merge of this? Has it been tested? |
Member
Author
|
The problem with this is that as of right now, there is no code. I'm asking lrvick to review the changes I made to his branch, but as of right now there's no way to compile the jinja2 templates and build something off of that. |
Member
Author
|
Conversation has been moved to #175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the plan for future deployments is:
This is key for
userdbbecause in order to useuserdbwe need to make the shell servers use it instead.This PR solves step 1. It can be either merged into the
strippedbranch locally, and then intoshell-server or moved directly to shell-server.
Feel free to correct me if any of this information is wrong.